Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for validation of target properties dictionaries #2272

Merged
merged 1 commit into from
May 1, 2024

Conversation

magnmaeh
Copy link
Member

@magnmaeh magnmaeh commented May 1, 2024

Fixes #2266.

The bug was just that return was inside the for-loop, so only the first key/value pair would be validated.

…dated the first

key/value pair of the dictionary.
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @magnmaeh!

@lhstrh lhstrh changed the title Fix validation of target properties dictionaries Fix for validation of target properties dictionaries May 1, 2024
@lhstrh lhstrh enabled auto-merge May 1, 2024 16:57
@lhstrh lhstrh added this pull request to the merge queue May 1, 2024
Merged via the queue into lf-lang:master with commit 52fa4fd May 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No validation on PlatformOption keys
3 participants