Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search for imported reactors to include reactors instantiated in modes #2277

Merged
merged 3 commits into from
May 8, 2024
Merged

Search for imported reactors to include reactors instantiated in modes #2277

merged 3 commits into from
May 8, 2024
+24 −0

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented May 8, 2024

Solves #2276

@erlingrj erlingrj added c Related to C target federated bugfix labels May 8, 2024
@erlingrj erlingrj requested a review from lhstrh May 8, 2024 17:28
lhstrh
lhstrh requested changes May 8, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but please add a test modeled after your example that fails without these changes.

@erlingrj erlingrj requested a review from lhstrh May 8, 2024 17:55
lhstrh
lhstrh approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lhstrh lhstrh changed the title Also search for imported reactors in modes Search for imported reactors to include reactors instantiated in modes May 8, 2024
@erlingrj erlingrj enabled auto-merge May 8, 2024 18:11
@erlingrj erlingrj added this pull request to the merge queue May 8, 2024
Merged via the queue into master with commit 6f77b37 May 8, 2024
24 checks passed
@erlingrj erlingrj deleted the fix-imports-with-feds-modes branch May 8, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
bugfix c Related to C target federated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlingrj @lhstrh