Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguate set(0) for C++ ports #2302

Merged
merged 1 commit into from
May 31, 2024
Merged

Disambiguate set(0) for C++ ports #2302

merged 1 commit into from
May 31, 2024
+28 −1

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented May 30, 2024

This pulls in lf-lang/reactor-cpp#57 and adds a new test case.

Fixes #2280

@cmnrd
Disambiguate set(0) for C++ ports
f731d64 
This pulls in lf-lang/reactor-cpp#57 and adds a new test
case.

Fixes #2280
@cmnrd cmnrd added cpp Related to C++ target bugfix labels May 30, 2024
@cmnrd cmnrd requested review from elgeeko1 and lhstrh May 30, 2024 21:29
@cmnrd cmnrd enabled auto-merge May 30, 2024 22:33
lhstrh
lhstrh approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@cmnrd cmnrd added this pull request to the merge queue May 31, 2024
Merged via the queue into master with commit ca30b0c May 31, 2024
26 checks passed
@cmnrd cmnrd deleted the cpp-set-zero branch May 31, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@elgeeko1 elgeeko1 Awaiting requested review from elgeeko1

Assignees
No one assigned
Labels
bugfix cpp Related to C++ target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port.set(0) in Cpp target generates compile error "ambiguous call of overloaded function"
2 participants
@cmnrd @lhstrh