Make files available in Docker runner image #2327
Conversation
petervdonovan
added
c
core/src/main/java/org/lflang/generator/docker/DockerGenerator.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/lflang/generator/docker/DockerGenerator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Other than stated comments/question, this looks like the right solution to me. Thanks for the fix, @petervdonovan!
….java Co-authored-by: Marten Lohstroh <[email protected]>
WalkthroughThe recent changes introduce a mechanism in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DockerGenerator
participant Dockerfile
User->>DockerGenerator: Specify files to include in Docker image
DockerGenerator->>DockerGenerator: Call generateCopyOfUserFiles()
DockerGenerator->>Dockerfile: Add COPY commands for each file
Dockerfile->>DockerImage: Build Docker image with specified files
DockerImage->>User: Docker image with user-specified files included
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- core/src/main/java/org/lflang/generator/docker/DockerGenerator.java (3 hunks)
- test/C/src/docker/RuntimeFilesPropertyContainerized.lf (1 hunks)
Additional comments not posted (1)
test/C/src/docker/RuntimeFilesPropertyContainerized.lf (1)
12-39: Ensure the test checks for correct file contents. The expected string should be verified for accuracy against the actual file contents.Verification successful
The test correctly checks the contents of the file
RuntimeFilesPropertyContainerized.lfagainst the expected string. The file contents match the expected string exactly.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the expected contents in the test match the actual file contents. # Test: Compare the expected string in the test with the actual file contents. cat test/C/src/docker/RuntimeFilesPropertyContainerized.lf | grep 'target C {'Length of output: 199
Script:
#!/bin/bash # Description: Display the full content of the test file for comparison with the expected string in the script. # Test: Output the entire file content. cat test/C/src/docker/RuntimeFilesPropertyContainerized.lfLength of output: 996
core/src/main/java/org/lflang/generator/docker/DockerGenerator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- core/src/main/java/org/lflang/generator/docker/DockerGenerator.java (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- core/src/main/java/org/lflang/generator/docker/DockerGenerator.java
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- test/C/src/docker/RuntimeFilesPropertyContainerized.lf (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- test/C/src/docker/RuntimeFilesPropertyContainerized.lf
Closes #2278.
Summary by CodeRabbit
New Features
Tests