Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed C++ docker generation for when cmake is not installed #2358

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fixed C++ docker generation for when cmake is not installed #2358

merged 1 commit into from
Jul 12, 2024
+28 −15

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Jul 12, 2024

No description provided.

@cmnrd cmnrd added enhancement Enhancement of existing feature docker Issue related to the docker support labels Jul 12, 2024
@cmnrd cmnrd requested a review from lhstrh July 12, 2024 13:59
lhstrh
lhstrh approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhstrh lhstrh added this pull request to the merge queue Jul 12, 2024
Merged via the queue into master with commit bc52337 Jul 12, 2024
26 checks passed
@lhstrh lhstrh deleted the cpp-docker-cmake-fix branch July 12, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
docker Issue related to the docker support enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmnrd @lhstrh