No segfault when Python reactions fail #2428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if a Python reaction fails with an exception, the exception is properly reported, but the process then segfaults. Here is a simple test case:
This PR eliminates the explicit call to
Py_FinalizeEx()
on failure, relying instead on the Python runtime's own shutdown hooks.Before this PR, running the above program results in the following:
After the change, we get this:
This PR also aligns reactor-c to main (again).