Port the C++ Generator to Kotlin #345

cmnrd · 2021-05-21T10:23:59Z

This branch ports the C++ code generator from Xtend to Kotlin. This effort is still a work in progress. I am opening this PR, so that everyone can see what is going on and get involved in a discussion about which "style" or patterns to use.

I configured this PR to compare against the branch kotlin-with-gradle. This way we can focus on the C++ related changes here. However, we will also need to merge the kotlin-with-gradle branch to make this PR work.

…strings

oowekyala

This looks really good! I think you already made yourself at home with extensions, my comments are really just minor nitpicks

org.lflang/src/org/lflang/generator/CppGenerator.kt

…tors

Co-authored-by: Clément Fournier <[email protected]>

lhstrh

Amazing work! There are some comments missing, but this will become more visible when we generate KDoc documentation, so we can also address it then.

…n-cpp-generator

org.lflang/src/org/lflang/generator/LFGenerator.java

cmnrd added 19 commits May 20, 2021 09:51

cpp: move the old xtend based generator

2577596

cpp: add minimal version of cpp generator in kotlin that compiles

99dd25b

cpp: add copyright header

6340d6b

cpp: add stub implementation of doGenerate()

bc655b2

cpp: port the check for main

aae7cd0

cpp: start by copying the static files

e904b7b

cpp: and (incomplete) port of the generateCmake method

f7de049

cpp: improve escaping of $ sign

d887fdc

cpp: use kotlins builtin TODO function

e2d667f

cpp: some improvements that intellij told me to do...

710a9b3

cpp: move control flow from string templates to code

35190ca

cpp: reorganizing code

a83e795

cpp: fixes

164ae30

cpp: properly handle severity levels

e339d90

cpp: add code for generating paths from resources/reactors

5bf3e0b

cpp: introduce the .. operator for handling indentation of multiline …

0a6c59d

…strings

cpp: list all generated source files in the cmake script

94e6a88

cpp: clean up a little

9241209

cpp: remove ported code from old xtend file

97b4138

cmnrd added compiler cpp Related to C++ target labels May 21, 2021

cmnrd requested review from lhstrh and oowekyala May 21, 2021 10:23

oowekyala reviewed May 21, 2021

View reviewed changes

cmnrd added 5 commits May 21, 2021 14:04

cpp: fix a typo and add a todo

8a59d63

cpp: add conversion functions for time units

8000616

cpp: add incomplete function for generating main.cc

402a785

cpp: port compilation code

8c7229c

cpp: bugfix

e71693f

cmnrd and others added 6 commits June 14, 2021 12:59

cpp: fix typo

681a8bc

cpp: report errors instead of throwing exceptions

1b2160c

cpp: move code for accessing validated widths to port/instance genera…

9a4f5ba

…tors

cpp: remove unnecessary extension

e613199

Update org.lflang/src/org/lflang/AstExtensions.kt

502f079

Co-authored-by: Clément Fournier <[email protected]>

Update org.lflang/src/org/lflang/AstExtensions.kt

c4905ce

Co-authored-by: Clément Fournier <[email protected]>

lhstrh approved these changes Jun 14, 2021

View reviewed changes

cmnrd added 4 commits June 15, 2021 09:53

Merge remote-tracking branch 'origin/kotlin-cpp-generator' into kotli…

d2be292

…n-cpp-generator

Merge branch 'kotlin-with-gradle' into kotlin-cpp-generator

827caf4

cpp: fix typo in reactor-cpp

6f8f90b

Merge branch 'kotlin-with-gradle' into kotlin-cpp-generator

0090971

cmnrd mentioned this pull request Jun 18, 2021

Properly implement scoping rules in the generated C++ code #375

Merged

cmnrd added 8 commits June 25, 2021 10:01

Merge branch 'kotlin-with-gradle' into kotlin-cpp-generator

80dc16a

generator: port changes from LFGenerator.kt back to LFGenerator.java

bfb004f

cpp: make sure that LFGenerator works properly if run from Eclipse

4a959ca

generator: port the error reporter to Java

e50ce87

generator: Display a proper error if the generator cannot be found

d927e04

Merge branch 'kotlin-with-gradle' into kotlin-cpp-generator

a1e8546

Merge branch 'kotlin-with-gradle' into kotlin-cpp-generator

caba3c8

idea: push my code style settings

3c2c49a

cmnrd mentioned this pull request Jun 29, 2021

Support definition of methods similar to state variables #382

Merged

lhstrh changed the base branch from kotlin-with-gradle to master June 29, 2021 18:45

lhstrh changed the title ~~WIP: Port the C++ Generator to Kotlin~~ Port the C++ Generator to Kotlin Jun 29, 2021

lhstrh reviewed Jun 29, 2021

View reviewed changes

org.lflang/src/org/lflang/generator/LFGenerator.java Outdated Show resolved Hide resolved

Update org.lflang/src/org/lflang/generator/LFGenerator.java

cf24190

lhstrh approved these changes Jun 29, 2021

View reviewed changes

lhstrh merged commit 83ba25f into master Jun 29, 2021

lhstrh deleted the kotlin-cpp-generator branch June 29, 2021 20:57

edwardalee mentioned this pull request Jun 29, 2021

Fresh oomph install has problems #383

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port the C++ Generator to Kotlin #345

Port the C++ Generator to Kotlin #345

cmnrd commented May 21, 2021 •

edited

Loading

oowekyala left a comment

lhstrh left a comment

Port the C++ Generator to Kotlin #345

Port the C++ Generator to Kotlin #345

Conversation

cmnrd commented May 21, 2021 • edited Loading

oowekyala left a comment

Choose a reason for hiding this comment

lhstrh left a comment

Choose a reason for hiding this comment

cmnrd commented May 21, 2021 •

edited

Loading