Add support for cross connections #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add a check to the validator that produces an error if that feature is used in another target than C++
…ified the iterator over banks and multiports; it is much clearer code now.
edwardalee
reviewed
Jul 22, 2021
this replaces the -x-> operator used on connections before
This makes the integration with the existing code base significantly easier, but requires more validator rules
|
I pushed some new changes that address @edwardalee's comments. Most importantly, the syntax changed, and we can now use interleaved on port references I extended the tests so that they include both cases, and also added a test that checks the correct operation in conjunction with after. |
edwardalee
approved these changes
Jul 28, 2021
|
@edwardalee I added a description of this feature to the bottom of Multiports and Banks of Reactors. Could you check this description and see if it is understandable? |
|
Nice! I added to Multiports and Banks of Reactors an explanation of the addressing scheme that results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for so-called interleaved connections using the
interleaved(b.p)qualifier that can be optionally added to a port referenceb.p. Normally, the connection logic would iterate first over banks, then multiports, on both sides of the connection. If the interleaved qualifier is used, this pattern is changed for the specified port and ports are iterated before banks. This allows creating patterns where bank instances can send messages to a specific second instance. See #415 for more details and a usage example.Closes #415