fix lfc rebuild #524
fix lfc rebuild #524
Conversation
There was a problem hiding this comment.
While lfc -r does not throw an error anymore, the smart rebuilding mechanism does not seem to work on my machine.
For example, changing something in CGenerator.xtend does not cause lfc -r to rebuild:
lfc -r
lfc: info: Not rebuilding; already up-to-date.
lfc: fatal error: No input files.
Is this issue repeatable on your machine as well @cmnrd?
|
@Soroosh129: it works for me... |
|
I also don't understand what's the problem. You say that the "smart rebuilding mechanism doesn't seem to work," but the output you shared shows that it does work ( |
Hmm. As I said, if I change something in CGenerator.xtend, I'd expect to get a rebuild, but I instead get this message that says everything is already up to date. Here is my original comment:
|
|
Oh, I see. You’re saying it doesn’t build when it should. I thought the
problem was that it built when it shouldn’t have. Let me check again.
On Tue, Sep 21, 2021 at 1:07 PM Soroush Bateni ***@***.***> wrote:
I also don't understand what's the problem. You say that the "smart
rebuilding mechanism doesn't seem to work," but the output you shared shows
that it *does* work (lfc: info: Not rebuilding; already up-to-date.).
Hmm. As I said, if I change something in CGenerator.xtend, I'd expect to
get a rebuild, but I instead get this message that says everything is
already up to date. Here is my original comment:
For example, changing something in CGenerator.xtend does not cause lfc -r
to rebuild:
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#524 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYD47CRHQJS2ZCROF2VGXTUDDQZLANCNFSM5EOO2WKQ>
.
--
…--
Marten Lohstroh | Postdoctoral Researcher
University of California | 545Q Cory Hall
Berkeley, CA 94720 | +1 510 282 9135
|
|
@soroush: I'm not able to reproduce this behavior. If the problem persists, please create an issue for it. I'm going ahead and will merge in this fix. |
You know, it would be really nice if you guys stop mentioning me; otherwise I would have to join the project and start fixing bugs (: |
|
You're very welcome to come and join the project, @soroush! As you probably can tell by now, we could use some bug fixers :-D I'm sorry this keeps happening; I wish GitHub threw a warning when mentioning folks that are unrelated to the project. |
|
It's a nice handle you got there 👀 |
|
I can reproduce @Soroosh129's behavior and I am actually surprised that it seems to work for @lhstrh. Currently, the rebuild logic only checks for changes in |
|
It’s because I changed something in org.lflang :-)
On Wed, Sep 22, 2021 at 12:45 AM Christian Menard ***@***.***> wrote:
I can reproduce @Soroosh129 <https://github.com/Soroosh129>'s behavior
and I am actually surprised that it seems to work for @lhstrh
<https://github.com/lhstrh>. Currently, the rebuild logic only checks for
changes in org.lf-lang.lf but not in org.lf-lang. I will try to create a
fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#524 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYD47A4IQXYBSB7AFJ2FCDUDGCPZANCNFSM5EOO2WKQ>
.
--
…--
Marten Lohstroh | Postdoctoral Researcher
University of California | 545Q Cory Hall
Berkeley, CA 94720 | +1 510 282 9135
|
But that is where lfc currently doesn't check ;) Anyway, I started to fix this issue in lfc, but mid-way I realized that the rebuild feature is very hacky and makes a few assumptions. This leads to things breaking down if the assumptions aren't true. This sis for instance the case when we run a pre-built lfc. We currently have |
|
Yeah, I meant org.lflang.lfc; the Main class, to be specific.
|
closes #521