Support after on connections composed of multiple single ports #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardalee
approved these changes
Sep 27, 2021
|
I guess the Python target was overlooked? Going forward, how should we handle branches with new tests? I'd be more than happy to add the Python-equivalent test in any given branch if the author pings me. |
|
That is a good question. I wasn't even aware that Python supports multiports, and I wouldn't have known to ping you. So I guess a good first step would be the feature matrix that we discussed a while ago. Maybe we should just be a bit slower with merging and give everyone the opportunity to have a look. I think the code review is the perfect place to comment on missing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we connect multiple individual ports (not multiports) like so
o1, o2 -> i1, i2, then after delays do not work as expected. If only single ports are involved, the connection is still treated as a single port connection. This PR modifies theisWidemethod to also return true, if multiple ports are listed on either side. This small change is sufficient to get after delays working as expected on such connections. I also added a C and a C++ test.