Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python target: Allow the execution of async Python threads concurrently with the C runtime #564

Merged
merged 6 commits into from
Oct 3, 2021
Merged

Python target: Allow the execution of async Python threads concurrently with the C runtime #564

merged 6 commits into from
Oct 3, 2021

Conversation

Soroosh129
Copy link
Contributor

Fixes #563.

@Soroosh129 Soroosh129 mentioned this pull request Oct 2, 2021
Closed
@codecov
Copy link

codecov bot commented Oct 2, 2021 •
edited
Loading

Codecov Report

Merging #564 (77acbd1) into master (620d437) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #564      +/-   ##
============================================
+ Coverage     66.41%   66.43%   +0.01%     
+ Complexity     3474     3466       -8     
============================================
  Files           132      132              
  Lines         22311    22294      -17     
  Branches       2885     2876       -9     
============================================
- Hits          14817    14810       -7     
+ Misses         6351     6345       -6     
+ Partials       1143     1139       -4
Impacted Files Coverage Δ
org.lflang/src/org/lflang/TargetProperty.java 85.75% <100.00%> (ø)
...tend-gen/org/lflang/generator/PythonGenerator.java 80.29% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620d437...77acbd1. Read the comment docs.

@Soroosh129 Soroosh129 changed the title Allow the execution of async threads concurrently with the C runtime Python target: Allow the execution of async threads concurrently with the C runtime Oct 2, 2021
@Soroosh129 Soroosh129 changed the title Python target: Allow the execution of async threads concurrently with the C runtime Python target: Allow the execution of async Python threads concurrently with the C runtime Oct 2, 2021
@Soroosh129 Soroosh129 requested a review from edwardalee October 2, 2021 15:22
@Soroosh129 Soroosh129 mentioned this pull request Oct 2, 2021
Merged
lhstrh
lhstrh approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good solution to me!

@lhstrh lhstrh merged commit 9087aa8 into master Oct 3, 2021
@lhstrh lhstrh deleted the python-allow-async-threads-concurrently branch October 3, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@edwardalee edwardalee Awaiting requested review from edwardalee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python target does not schedule physical action when timer reaction is absent.
2 participants
@Soroosh129 @lhstrh