Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and flag and as error multiple mains #965

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Detect and flag and as error multiple mains #965

merged 3 commits into from
Feb 16, 2022

Conversation

edwardalee
Copy link
Collaborator

This PR fixes #905.

@edwardalee edwardalee mentioned this pull request Feb 16, 2022
Closed
@lhstrh
Copy link
Member

lhstrh commented Feb 16, 2022

Looks good! Before merging, we should add/enable the test case that it fixes as a unit tests.

housengw
housengw approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@housengw housengw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmnrd cmnrd merged commit df8257d into master Feb 16, 2022
@housengw housengw deleted the multiple-mains branch March 10, 2022 23:49
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh changed the title Detect and flag and as error multiple mains. Detect and flag and as error multiple mains Mar 17, 2022
@lhstrh lhstrh added the bug Something isn't working label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housengw housengw housengw approved these changes

@lhstrh lhstrh Awaiting requested review from lhstrh

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Having multiple unnamed main reactors causes nullPointerException
4 participants
@edwardalee @lhstrh @housengw @cmnrd