Added --version flag to lfcand improved error messages
#979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Nice! We'll have to make sure to keep updating the version string in Main.java. I'm thinking there might also be other places where we might want to display a version number (we probably already are), so I think we might want to move the version string into the main org.lflang package. We can do that at a later time. I created an issue: #980
lhstrh
changed the title
--version flag to lfcand improved error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the features requested in #919 and #927. These are a
--versionCLI argument for lfc and an improved error message when lfc is run on a none-LF file.Closes #919
Closes #927