Code in rti.c made available as library

[Jakio815]

No description provided.

[Jakio815]

I think it will work if the main branch reverts to commit 4f78b42a which was the commit just before I started pushing. I also merged #169 together what you merged right after my PR. Would you please have a look? @lhstrh.

Tell me if I shouldn't merge #169 together. I'll revert it.

[edwardalee]

This PR also seems to loose the history. Note that rti_lib.c is entirely authored by @Jakio815 even though it is mostly copied from rti.c.

[lhstrh]

The trick is to use git mv for the file that will carry most of the history and create new ones for the smaller ones... Whatever gets factored out, however, will not of course loose history, there is no way around that.

[lhstrh]

@Jakio815 did you see the link that @erlingrj shared about doing this?

[edwardalee]

You can preserve the history even on the smaller file, although it may not be worth the trouble if it is small enough. See:

https://devblogs.microsoft.com/oldnewthing/20190916-00/?p=102892

[Jakio815]

I'm not sure what you are mentioning. Are you mentioning this?

And actually when I checkout to this branch, I see the file history. I followed the link above which professor @edwardalee mentioned. I see that the Git's Files Changed tap seems to change everything, but in my VSCode GitLens extension, it has the original history. I'm not sure if this is the right way. Would you please check? @lhstrh

[edwardalee]

Oh, interesting. Yes, it could be just that the history doesn't show up in Files Changed. I hadn't realized that, but it makes sense.

[Jakio815]

I also see that the contributors for rti_lib.c is only me. I'm not sure how I can check this on the Github web.

[Jakio815]

I found out that if you tap 'Blame', you could see the history of every lines. Also, if you tap the 'History' you could check the history below saying that it was renamed.

Sorry for bothering everyone with this problem.

[lhstrh]

I reverted my merge commit of the previous PR, so once approved, you can just go ahead and hit the merge button. Please mark it "ready for review" so that @edwardalee can approve it. Thanks!

[edwardalee]

LGTM! Thanks for fixing this.