Compile definitions for federated programs #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the integration test failed deterministically for a reason unrelated to what I did in this branch. I don't know how this happened, and I do not know why the bug which is fixed in lingua-franca/do-not-report-warnings-as-errors did not surface earlier.
petervdonovan
force-pushed
the
cmake-cleanup
branch
from
54ce25d to
523d21f
Compare
|
Do you have any idea what is going on here @erlingrj ? The Zephyr test is the only one that this branch has not been able to pass. I did not make changes related to Zephyr tests, and I failed to reproduce the problem locally using Zephyr version 3.2.99 (after changing the generated CMakeLists to let me try 3.2.99). I am also re-running CI on |
|
Should be fixed in LF master now. The problem was that I was using a Zephyr docker image in CI and I used the |
petervdonovan
commented
Mar 15, 2023
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: lf-lang/lingua-franca#1622