Change nanosleep to lf_sleep in federate and RTI code #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. For reference, Silje is merging in the changes required to run the RTI as a user thread on the Zephyr platform. @Benichiwa on the macos target we are getting a strange-looking Watchdog failure. Can you make anything of it? It is surely not caused by this PR. |
|
This Watchdog failure looks to me like something is trying to happen after the program has shut down. I will take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform abstraction for sleep is already available as lf_sleep(), and should be used instead of nanosleep() in the federate and RTI code. Timespec structs can then be removed entirely and just use the available macros or variables in nanoseconds as input to lf_sleep().
CONNECT_RETRY_INTERVAL is changed to be in nanoseconds instead of seconds, as the other macros.