-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTI exit while saving the trace file #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and suggestions. Thanks for fixing the printf format warnings too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition to the RTI :)
@edwardalee and @erlingrj, I still don't get why the tests are not passing. |
I have no idea why these tests are not passing. Looks like a socket connection was broken while downloading gradle? @petervdonovan : any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I don't think the test failures have anything to do with these changes.
BTW, |
Co-authored-by: Edward A. Lee <[email protected]>
Three tests failed, all for different reasons:
EDIT: Raised an issue: lf-lang/lingua-franca#1819 EDIT: The bottom line is that I agree with Edward that the test failures are probably unrelated to these changes. |
This PR enables saving the trace file of the RTI, also after receiving a kill (Ctrl-C) signal.
This will help with debugging failing federated executions.