Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enclave request stop #244

Merged
merged 25 commits into from
Jun 30, 2023
Merged

Enclave request stop #244

merged 25 commits into from
Jun 30, 2023

Conversation

edwardalee
Copy link
Contributor

This PR reworks lf_request_stop() to work with enclaves. It no longer requires an environment argument and it should also work with federations.

@edwardalee edwardalee mentioned this pull request Jun 28, 2023
Merged
@edwardalee edwardalee requested a review from erlingrj June 28, 2023 13:51
@erlingrj
Copy link
Collaborator

I will review this tomorrow morning

erlingrj
erlingrj approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. I just had a suggestion for differentiating between having previously sent a stop request and having previously received a stop request.

I also took the liberty to make a few minor changes in the code and commit them.

core/federated/federate.c Outdated Show resolved Hide resolved
core/federated/federate.c Outdated Show resolved Hide resolved
core/federated/federate.c Outdated Show resolved Hide resolved
erlingrj
erlingrj approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :)

@lhstrh lhstrh merged commit f05fb5d into main Jun 30, 2023
@lhstrh lhstrh deleted the enclave-request-stop branch June 30, 2023 14:25
@lhstrh lhstrh added the feature New feature label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlingrj erlingrj erlingrj approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardalee @erlingrj @lhstrh