Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect ZDC in RTI and issue PTAG only for nodes in ZDC #311

Merged
merged 58 commits into from
Dec 2, 2023
Merged

Detect ZDC in RTI and issue PTAG only for nodes in ZDC #311

merged 58 commits into from
Dec 2, 2023

Conversation

edwardalee
Copy link
Contributor

@edwardalee edwardalee commented Nov 23, 2023 •
edited
Loading

This PR makes a number of changes, the most important of which is to analyze the topology of the connections between nodes (federates or enclaves), calculate the minimum delay path between every pair of nodes, and use PTAG only when a node is in a zero-delay cycle (ZDC).

Note that this PR includes pqueue_refactoring. Merge #306 first to make this PR smaller.

A missing component is that federates are sending absent messages always. They should only send absent messages on output ports that are part of a zero-delay cycle.

edwardalee and others added 30 commits October 28, 2023 12:31
@edwardalee
Point lingua-franca-ref.txt to master to see whether we can get tests…
7be7465 
… to pass.
@edwardalee
Put current fed/enclave into visited array
2807e1d
@edwardalee
Update lingua-franca-ref.txt to point to enclaves3 branch.
fa8bbc3
@edwardalee
Fix function template
c6343fe
@edwardalee
Acquire global mutex, not enclave-local one
d336937
@edwardalee
Merge branch 'enclaves2' into enclaves3
8f78134
@edwardalee
Fixing transitive next event
fc7b300
@edwardalee
Reverted mutex change
1e44a45
@edwardalee
Added comment about precomputing shortest path
15dbee7
@edwardalee
Removed comments from .c file and tuned comments
f5f7a5e
@edwardalee
Print federate name for lf_print
fceeb9d
@edwardalee
Moved _lf_get_environments to environment.h
4648bff
@erlingrj
Implement _lf_get_environments stub for unit tests
dfb515e
@edwardalee
Removed not too helpful debug message
7548cfc
@edwardalee
Enabled compilation for standalone RTI
fbf9950
@edwardalee
Typo
6ce3364
@edwardalee
Handle cycles better
fd98f3a
@edwardalee
Merge branch 'enclaves2' into enclaves3
a97fdc1
@edwardalee
Malloc memory only for array sizes > 0
1a05436
@edwardalee
Free dynamically allocated memory
f7c80af
@erlingrj
Merge remote-tracking branch 'origin/main' into enclaves3-erj
6f77e1c
@erlingrj
Merge branch 'enclaves2' into enclaves3
19249c8
@erlingrj
add _locked version of stop_trace to be called from within critical s…
158260b 
…ection
@edwardalee
Protect next_reaction_level against overflow
4e9c1a2
@edwardalee
Resolved merge conflicts on comments (only).
e4bae13
@erlingrj
Update lf-ref
c270761
@erlingrj
Fix superflous newline in logging
6d67ceb
@erlingrj
RTI: Add zero-delay-cycle detection
f9e787b
@erlingrj
RTI: Only give a PTAG if there is a zero-delay cycle
65f491c
@erlingrj
RTI: Print out ZDC detected by the RTI
a192cf9
edwardalee and others added 15 commits November 18, 2023 17:46
@edwardalee edwardalee added enhancement Enhancement of existing feature federated labels Nov 23, 2023
@edwardalee edwardalee marked this pull request as ready for review November 23, 2023 18:00
@edwardalee edwardalee requested a review from erlingrj November 23, 2023 18:00
@byeonggiljun byeonggiljun mentioned this pull request Nov 24, 2023
Closed
erlingrj
erlingrj approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I only had a few questions. I did not look at the pqueue-refactorings as I currently don't have the context for this.

core/federated/RTI/rti_common.c Outdated Show resolved Hide resolved
core/federated/RTI/rti_common.c Outdated Show resolved Hide resolved
core/federated/RTI/rti_remote.c Show resolved Hide resolved
@edwardalee
Copy link
Contributor Author

I have resolve @erlingrj 's comment. @lhstrh : Ok to merge this? You mentioned you had a draft review in progress, I think.

lhstrh
lhstrh reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good although I don't think I fully comprehend the full extend of the implications of these changes. I had some minor questions...

test/src_gen_stub.c Outdated Show resolved Hide resolved
include/core/trace.h Show resolved Hide resolved
core/utils/util.c Show resolved Hide resolved
@edwardalee edwardalee merged commit 2fb2878 into main Dec 2, 2023
28 checks passed
@lhstrh lhstrh deleted the enclaves3 branch December 2, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh left review comments

@erlingrj erlingrj erlingrj approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature federated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edwardalee @lhstrh @erlingrj @byeonggiljun