Add address query reply message #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardalee
approved these changes
Feb 27, 2024
lhstrh
force-pushed
the
address_query_reply
branch
from
79884bb to
db70d4e
Compare
Co-authored-by: Edward A. Lee <[email protected]>
Jakio815
changed the title
|
Is there a plan on how we manage the updating of the RTI? How do we tell this to users? How do we even know if the running RTI is using the right version? Perhaps we shouldn't expect the RTI to be installed in the system until we have a proper versioning system. We can simply compile it alongside the federates and also place it in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In decentralized coordination, the federate sends MSG_TYPE_ADDRESS_QUERY to the RTI with the payload being the ID of the federate it wishes to connect to.
Then, the RTI will reply with the remote federate's port number and IP address, using the same message header MSG_TYPE_ADDRESS_QUERY.
I suggest the reply message header to be changed from MSG_TYPE_ADDRESS_QUERY to MSG_TYPE_ADDRESS_QUERY_REPLY.
I just pushed the MSG_TYPE number down. Since 18 was empty, didn't need to push down all the numbers. Future work will to make it in enums.
Since this changes the protocol after this merge, the RTI must be rebuilt.