Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of negative value passed in as the number of federates #411

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

chanijjani
Copy link
Collaborator

@chanijjani chanijjani commented Apr 14, 2024

Invoke error returns when negative values are given as the number of federates and delete unreachable code found by the code coverage with unit test cases in Rust RTI.

@chanijjani chanijjani self-assigned this Apr 14, 2024
Invoke error returns when negative values are given as the number
of federates and delete unreachable code found by the code coverage
with unit test cases in Rust RTI.

Signed-off-by: Chanhee Lee <[email protected]>
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@lhstrh lhstrh enabled auto-merge April 14, 2024 05:08
@lhstrh lhstrh changed the title Fix a negative value acceptance as the number of federates Properly handle negative value passed in as the number of federates Apr 14, 2024
@lhstrh lhstrh changed the title Properly handle negative value passed in as the number of federates Proper handling of negative value passed in as the number of federates Apr 14, 2024
@lhstrh lhstrh added this pull request to the merge queue Apr 14, 2024
Merged via the queue into lf-lang:main with commit 8a9a23d Apr 14, 2024
30 checks passed
@chanijjani chanijjani deleted the fix-argument branch April 15, 2024 01:17
@chanijjani
Copy link
Collaborator Author

Thanks for the fix!

@lhstrh Thank you for updating the PR title! I'll update similar fixes continually whenever I find them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants