-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clock sync init option #414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, my bad for not including the _LF_CLOCK_SYNC_INITIAL
compiler flag when I did that refactoring.
However, I don't see how this should affect flakyness? If all federations run on the same host, then running clock sync between them will just introduce clock sync error.
This PR fixes a bug where clock synchronization was not being done when the clock-sync target option was set to
init
, which is the default.This also fixes a bug where if the clock-sync-options field collect-stats was set to true, stats would not be collected.
This also fixes an unrelated warning in net_util.c.