Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clock sync init option #414

Merged
merged 11 commits into from
Apr 25, 2024
Merged

Fix clock sync init option #414

merged 11 commits into from
Apr 25, 2024

Conversation

edwardalee
Copy link
Contributor

@edwardalee edwardalee commented Apr 25, 2024

This PR fixes a bug where clock synchronization was not being done when the clock-sync target option was set to init, which is the default.

This also fixes a bug where if the clock-sync-options field collect-stats was set to true, stats would not be collected.

This also fixes an unrelated warning in net_util.c.

Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, my bad for not including the _LF_CLOCK_SYNC_INITIAL compiler flag when I did that refactoring.

However, I don't see how this should affect flakyness? If all federations run on the same host, then running clock sync between them will just introduce clock sync error.

@edwardalee edwardalee added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit aa1e78b Apr 25, 2024
30 checks passed
@erlingrj erlingrj deleted the clock-sync branch May 6, 2024 09:12
@erlingrj erlingrj restored the clock-sync branch May 13, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants