Unit testing of thread scheduling API + additional fixes #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
erlingrj
commented
Apr 28, 2024
•
erlingrj
commented
- Add unit test of the scheduling API
- Fix a few more issues in the scheduling API
- Improve unit test CMake system
- Move RTI unit tests to the RTI folder and reuse the original CMake script
- Disable unit tests on Windows. They haven't been running anyways.
- Only accept unsigned CPU ids - Set priority to 0 for SCHED_OTHER - Only cal lf_thread_set_priority for SCHED_RR and SCHED_FIFO
erlingrj
force-pushed
the
thread-sched-test-and-fix
branch
from
4d34d7d to
7b04b8a
Compare
erlingrj
force-pushed
the
thread-sched-test-and-fix
branch
from
7b04b8a to
0fe300f
Compare
|
OK, @lhstrh this is finally ready for review |
lhstrh
reviewed
Apr 29, 2024
|
@lhstrh the comments should all be addressed now |
lhstrh
approved these changes
Apr 29, 2024
Co-authored-by: Marten Lohstroh <[email protected]>
|
We appear to have a problem with |
lhstrh
approved these changes
Apr 29, 2024
lhstrh
changed the title
|
It looks like unit tests were disabled for Windows, but we still expect them to pass in order to be pushed onto the merge queue... |
lhstrh
reviewed
Apr 30, 2024
erlingrj
force-pushed
the
thread-sched-test-and-fix
branch
from
b6afbaf to
a1e043b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.