Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in lf_watchdog_stop #417

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix race condition in lf_watchdog_stop #417

merged 1 commit into from
May 2, 2024

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented May 2, 2024 •
edited
Loading

This PR addresses a race condition exposed when lf_watchdog_start and lf_watchdog_stop was called in very close succession.

@erlingrj erlingrj requested a review from edwardalee May 2, 2024 13:21
@erlingrj erlingrj added the bugfix label May 2, 2024
edwardalee
edwardalee approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

@erlingrj erlingrj enabled auto-merge May 2, 2024 14:04
@erlingrj erlingrj added this pull request to the merge queue May 2, 2024
@erlingrj erlingrj removed this pull request from the merge queue due to a manual request May 2, 2024
@erlingrj erlingrj added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit f64c02d May 2, 2024
28 checks passed
@erlingrj erlingrj deleted the watchdog-fix branch May 6, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlingrj @edwardalee