Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let pthread detect if the cpu number is valid #436

Merged
merged 2 commits into from
May 24, 2024
Merged

Let pthread detect if the cpu number is valid #436

merged 2 commits into from
May 24, 2024

Conversation

erlingrj
Copy link
Collaborator

Previously we just checked if the cpu_number > NUM_CPUs. However this does not work reliable if we pin the process to a subset of the CPUs.

@erlingrj erlingrj added enhancement Enhancement of existing feature schedulers labels May 23, 2024
@lhstrh lhstrh requested a review from petervdonovan May 24, 2024 00:53
@petervdonovan petervdonovan enabled auto-merge May 24, 2024 03:46
petervdonovan
petervdonovan approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree that this is simpler and better and maintains compliance with the doc comment of the function.

@petervdonovan petervdonovan added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 6424fa5 May 24, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petervdonovan petervdonovan petervdonovan approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature schedulers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlingrj @petervdonovan