Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes in decentralized coordination #476

Merged
merged 12 commits into from
Aug 8, 2024
Merged

Bugfixes in decentralized coordination #476

merged 12 commits into from
Aug 8, 2024

Conversation

edwardalee
Copy link
Contributor

@edwardalee edwardalee commented Aug 3, 2024

This PR fixes a number of issues with STA and STAA in decentralized coordination. There is a companion PR in lingua-franca. In particular:

  • It enables using large values when the data flow is predictable.
  • It changes terminology to use STA and STAA.
  • It guards against overflow of time values, allowing large STA and STAA.
  • It ensures that STA is always added to STAA.
  • It moves the logic of whether to add the STA out of wait_until and into the federated code.
  • It makes sure the stop tag is completed before exiting.

@edwardalee edwardalee added enhancement Enhancement of existing feature bugfix federated labels Aug 3, 2024
@edwardalee edwardalee changed the title First pass at making dataflow work with decentralized Improvements to decentralized coordination Aug 5, 2024
@edwardalee edwardalee requested review from Depetrol and lhstrh August 5, 2024 22:24
@edwardalee edwardalee marked this pull request as ready for review August 5, 2024 22:24
Copy link
Collaborator

@Depetrol Depetrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great improvement for decentralized coordination, using STA & STAA could really reduce a lot of the confusion about STP. I can confirm that this solves lf-lang/lingua-franca#2373.

core/federated/federate.c Show resolved Hide resolved
@lhstrh
Copy link
Member

lhstrh commented Aug 6, 2024

There are non-deterministic failures lurking somewhere. The CI run based 21dee16 failed, but the subsequent run based on 89b0e36 passed, even though that commit only includes comments...

@edwardalee
Copy link
Contributor Author

edwardalee commented Aug 6, 2024

There are non-deterministic failures lurking somewhere. The CI run based 21dee16 failed, but the subsequent run based on 89b0e36 passed, even though that commit only includes comments...

No, this branch points to a branch of limgua-franca, which changed. So this is not a nondeterministic failure.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edwardalee edwardalee added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 89435b3 Aug 8, 2024
49 of 50 checks passed
@lhstrh lhstrh removed the enhancement Enhancement of existing feature label Sep 22, 2024
@lhstrh lhstrh changed the title Improvements to decentralized coordination Bugfixes in decentralized coordination Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants