Prevent hanging on waiting for timeout time #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still meant to be a draft? |
lhstrh
reviewed
Aug 25, 2024
lhstrh
reviewed
Aug 25, 2024
lhstrh
reviewed
Aug 25, 2024
Co-authored-by: Marten Lohstroh <[email protected]>
lhstrh
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a corner case where a federate with decentralized coordination that had no events at the timeout tag and has a large STA would hang even when its upstream federates exit and close the socket connection. The fix is to set the last known tag for input federates to
FOREVER_TAGwhen a socket connection is closed.It has a companion PR in lingua-franca