Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect multiports from accidental modification by restricting Multiport and introducing new class ModifyableMultiport #33

Merged
merged 12 commits into from
Nov 1, 2022
Merged

Protect multiports from accidental modification by restricting Multiport and introducing new class ModifyableMultiport #33

merged 12 commits into from
Nov 1, 2022

Conversation

tanneberger
Copy link
Member

@tanneberger tanneberger commented Oct 21, 2022 •
edited by cmnrd
Loading

Summary

  • adding ModifyableMultiport
  • Multiport is now a restricted Interface class

Closes #30

@tanneberger tanneberger added the enhancement Enhancement of existing feature label Oct 21, 2022
@tanneberger tanneberger requested a review from cmnrd October 21, 2022 00:33
@tanneberger tanneberger self-assigned this Oct 21, 2022
@cmnrd cmnrd changed the title MultiportInterface class Protect multiports from accidental modification by restricting Multiport and introducing new class ModifyableMultiport Oct 21, 2022
@tanneberger tanneberger mentioned this pull request Oct 31, 2022
Closed
@cmnrd cmnrd force-pushed the protected-multiports branch from 5096939 to 622a48b Compare November 1, 2022 09:28
cmnrd
cmnrd approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@cmnrd cmnrd mentioned this pull request Nov 1, 2022
Merged
@cmnrd cmnrd merged commit b31bd68 into master Nov 1, 2022
@cmnrd cmnrd deleted the protected-multiports branch November 1, 2022 10:33
@cmnrd cmnrd mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmnrd cmnrd cmnrd approved these changes

Assignees

@tanneberger tanneberger

Labels
enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent user code from modifying multiport contents
2 participants
@tanneberger @cmnrd