Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased coverage of unit tests in bank.ts, multiport.ts and port.ts #100

Merged
merged 7 commits into from
May 25, 2022
Merged

Increased coverage of unit tests in bank.ts, multiport.ts and port.ts #100

merged 7 commits into from
May 25, 2022

Conversation

goekberk
Copy link
Contributor

@goekberk goekberk commented May 11, 2022 •
edited
Loading

Coverage improvement summary (in terms of % lines):

  • bank.ts 47.83% to 100%
  • multiport.ts 88.89% to 100%
  • port.ts 85.71% to 98.3%

Previous Coverage:

Screen Shot 2022-05-11 at 13 11 41

Current Coverage:

Screen Shot 2022-05-18 at 13 22 12

@hokeun hokeun marked this pull request as draft May 11, 2022 04:18
@hokeun hokeun changed the title increasing unit tests in bank.ts, multiport.test.ts and port.errors.t… Increase coverage of unit tests in bank.ts, multiport.ts and port.ts May 11, 2022
@hokeun hokeun marked this pull request as ready for review May 25, 2022 04:17
@hokeun hokeun requested review from lhstrh and hokeun May 25, 2022 04:17
lhstrh
lhstrh approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @goekberk. This looks great! I'd be happy to merge this in.

__tests__/bank.ts
o: OutMultiPort<number> = new OutMultiPort(this, 2)
constructor(parent: Reactor) {
super(parent)
let allWriter = this.allWritable(this.o);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this line isn't necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. It escaped my notice.

@lhstrh lhstrh merged commit e2c3182 into lf-lang:master May 25, 2022
@lhstrh lhstrh added the testing label Jul 20, 2022
@lhstrh lhstrh changed the title Increase coverage of unit tests in bank.ts, multiport.ts and port.ts Increased coverage of unit tests in bank.ts, multiport.ts and port.ts Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@hokeun hokeun Awaiting requested review from hokeun

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goekberk @lhstrh