Fixes to the graph package and added tests #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CloverCho and I finished implementing Line 366 in 140e4b5 Line 369 in 140e4b5 |
lhstrh
reviewed
Jul 14, 2022
lhstrh
requested changes
Jul 15, 2022
|
|
||
| expect(() => { | ||
| this.connect(__in1, __out2) | ||
| }).toThrowError("New connection introduces direct feed through.") // dist port already in use |
There was a problem hiding this comment.
I believe that this test is wrong (even though it passes). Since there already is a mutation that establishes direct feed through, it doesn't seem like this connection should introduce it. I think the expected behavior here would be that the connection would be successful.
lhstrh
requested changes
Jul 23, 2022
|
I'm going to go ahead and merge this since this is to be merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the branch where @lhstrh, @hokeun, @CloverCho, and I worked.
After the #107 PR, we tested the basic graph test (
graph.test.ts) to find the error ofgraph.ts.