Add the microstep only when the actions are scheduled at the current tag #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I'm surprised to see the unit tests failing... |
Yeah right... I have to debug. |
|
Looks like the test might be wrong? At least we have better coverage than I thought :-) |
|
Yeah it's good for reactor-ts :). I think that else if statement cannot prevent the schedule at the exact current tag. I'm not sure though... |
lhstrh
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, when action A is scheduled by
actions.a.schedule(TimeValue.sec(1), null)at the tag (1 sec, 0), it is scheduled at the tag (2 sec, 1).reactor-ts/src/core/action.ts/#L97 is the reason of that.
We have to increment the microstep only when we try to schedule an action at the current tag.