Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the disconnect function #136

Merged
merged 12 commits into from
Feb 25, 2023
Merged

Implementation of the disconnect function #136

merged 12 commits into from
Feb 25, 2023

Conversation

Wonseo-C
Copy link
Collaborator

I have implemented the _disconnect() function in the Reactor class, which can now be utilized in Mutation. Additionally, I have added a new test called disconnect.test.ts to confirm that connections are successfully disconnected. Furthermore, I have included the disconnect portion in the simple.ts test.

@Wonseo-C Wonseo-C requested review from lhstrh and hokeun February 23, 2023 04:20
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left some minor comments...

__tests__/disconnect.test.ts Outdated Show resolved Hide resolved
src/core/reactor.ts Outdated Show resolved Hide resolved
src/core/reactor.ts Outdated Show resolved Hide resolved
src/core/reactor.ts Outdated Show resolved Hide resolved
@Wonseo-C Wonseo-C changed the title implement the disconnect function and create a corresponding test. implementation of the disconnect function and create a corresponding test. Feb 24, 2023
src/core/reactor.ts Outdated Show resolved Hide resolved
Copy link
Member

@hokeun hokeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

src/core/reactor.ts Outdated Show resolved Hide resolved
src/core/reactor.ts Outdated Show resolved Hide resolved
@lhstrh lhstrh changed the title implementation of the disconnect function and create a corresponding test. Implementation of the disconnect function Feb 25, 2023
@lhstrh lhstrh merged commit 30cbc44 into master Feb 25, 2023
@lhstrh lhstrh deleted the disconnect branch February 25, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants