Install the RTI while testing and Prevent unintended tag advancement #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
…e its tag above the stop requested tag
byeonggiljun
force-pushed
the
fix-federation
branch
from
7dbdae1 to
dc9f44a
Compare
byeonggiljun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
ci.ymlis modified to install the RTI while testing federated tests, and unintended tag advancement with thenullvalue ofgreatestTimeAdvanceGrantis inhibited.Relevant PR
lf-lang/lingua-franca#1752
The RTI should be installed while testing to run federated tests.
Also, the
nullvalue ofgreatestTimeAdvanceGrantmeans that there was no TAG message yet. Federates should wait for TAG messages.