Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index moved from src/core to src #153

Merged
merged 1 commit into from
May 20, 2023
Merged

Index moved from src/core to src #153

merged 1 commit into from
May 20, 2023

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented May 20, 2023 •
edited
Loading

This is done so that tsc puts the other .js files into lib/core even if there are not other files or directories in src due to npm excluding them based on .npmignore.

@lhstrh lhstrh changed the title Move index from src/core to src Index moved from src/core to src May 20, 2023
@lhstrh lhstrh mentioned this pull request May 20, 2023
Merged
2 tasks
@lhstrh lhstrh requested a review from petervdonovan May 20, 2023 05:14
petervdonovan
petervdonovan approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm satisfied with this solution!

@lhstrh lhstrh merged commit 7b1e23f into master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petervdonovan petervdonovan petervdonovan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhstrh @petervdonovan