Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports (reopen #154) #155

Merged
merged 1 commit into from
May 27, 2023

Conversation

axmmisaka
Copy link
Collaborator

This is addressed, and hopefully resolves #86
Everything removed exists here: https://github.com/lf-lang/lingua-franca/blob/master/org.lflang/src/org/lflang/generator/ts/TSImportPreambleGenerator.kt

I think #154's CICD doesn't work because it tries to get branch reference from this repo only but that PR is from my repo. We might need to change CICD workflow later, but let's fix it here for now......

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@lhstrh lhstrh marked this pull request as ready for review May 27, 2023 16:45
@lhstrh lhstrh merged commit fec7489 into master May 27, 2023
@axmmisaka axmmisaka deleted the axmmisaka/remove-unneeded-dependencies branch May 28, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign how command-line-args and command-line-usage modules work
2 participants