Draft: Add a special class for network receiver and sender reactors #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetworkSender reactors are registerd to an array of NetworkReactors. NetworkSender reactros does not require a port ID, so make it optional parameter. Output control reactions are registered to a set of reactions. It is executed by the function `_iterationComplete`.
The level of each reaction should be checked before do that reaction. However, it cannot be achieved if we execute output control reactions at the end of the logical tag. Thus, I made the reactionQ as 'protected' to push output control reactions into it. It is safe because only the App and FederatedApp can access that Q.
This was
unlinked from
issues
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a special class for the federated execution as network actions are managed by each network reactor, not the top-level federated reactor. The name of the class is
NetworkReactorinstead ofFederatedReactorbecause they are not federated and are used for processing network actions.