Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized footer final review #132

Merged

Conversation

aritrachatterjee7
Copy link
Contributor

@aritrachatterjee7 aritrachatterjee7 commented Feb 27, 2025

Title:
🚀 Fix: Footer Hover Animation & Link Redirection (Issue #119)

Description:
This PR resolves issue #119 by implementing the following improvements in the footer:

Changes Made:
Updated components/footer.tsx
Added CSS animations for hover effects
Fixed incorrect links

closes #119

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starknet-id ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 3:05pm

Copy link

vercel bot commented Feb 27, 2025

@aritrachatterjee7 is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

@aritrachatterjee7
Copy link
Contributor Author

@Marchand-Nicolas kindly review once

@aritrachatterjee7 aritrachatterjee7 changed the title Fix #119: Optimized footer final review Optimized footer final review Feb 27, 2025
Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Not really good on large screens

Can you play with the opacity only for the hover effect ? Instead of the gray color. Remove the zoom effect too

@Marchand-Nicolas Marchand-Nicolas added the ❌ Change request Change requested from reviewer label Feb 27, 2025
@aritrachatterjee7
Copy link
Contributor Author

@Marchand-Nicolas i have fixed the hover effect and have played with the opacity as you mentioned. The problem i am facing while solving the footer preview for the big screen is that, i have changed the code for big screens this time, but actually i cant preview it on my laptop, because in my laptop, its appearing okay, but for big screens it might be a issue. Could you please check once
Screenshot 2025-02-27 195244

Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect lgtm! Very good job

@Marchand-Nicolas Marchand-Nicolas merged commit ad58d93 into lfglabs-dev:testnet Feb 27, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ Change request Change requested from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback footer - Final review
2 participants