feat: port to starknet-react v2 & add notifications #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irisdv
added
the
🚧 In progress do not merge
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fricoben
requested changes
Oct 27, 2023
pages/[addressOrDomain].tsx
Outdated
| if (lastConnectedConnectorId === null) { | ||
| return; | ||
| } | ||
| // useLayoutEffect(() => { |
There was a problem hiding this comment.
ah yes, I dream of deleting this part! If you can't reproduce any of the wallet issues we had before, this goes !
| new InjectedConnector({ options: { id: "braavos" } }), | ||
| new InjectedConnector({ options: { id: "argentX" } }), | ||
| braavos(), | ||
| argent(), |
ayushtom
reviewed
Oct 27, 2023
| > | ||
| <div className={styles.menu}> | ||
| <button className={styles.menu_close} onClick={closeModal}> | ||
| <svg viewBox="0 0 24 24"> |
There was a problem hiding this comment.
should we keep this icon in a seperate file like we do for other svgs?
There was a problem hiding this comment.
yes actually it was already in there, so I updated
fricoben
added
❌ Change request
irisdv
added
🔥 Ready for review
fricoben
requested changes
Oct 29, 2023
components/UI/wallets.tsx
Outdated
| @@ -30,7 +30,8 @@ const Wallets: FunctionComponent<WalletsProps> = ({ | |||
| }, [account, closeWallet]); | |||
|
|
|||
| function connectWallet(connector: Connector): void { | |||
| connect(connector); | |||
| console.log("connecting", connector); | |||
pages/index.tsx
Outdated
| return ( | ||
| <div className={styles.screen}> | ||
| <div className={styles.container}> | ||
| <div className={styles.blur1}> | ||
| <Blur /> | ||
| </div> | ||
| {/* For testing purposes */} | ||
| <div onClick={submitTx}>Send test tx</div> |
There was a problem hiding this comment.
to delete with all the test code ! I tested everything works great 🫡
fricoben
added
❌ Change request
irisdv
added
🔥 Ready for review
fricoben
requested changes
Oct 31, 2023
components/UI/navbar.tsx
Outdated
| color={theme.palette.secondary.dark} | ||
| /> | ||
| )} | ||
| </li> | ||
| {/* Note: I'm not sure that our testnet will be public so we don't show any link */} | ||
| {/* <SelectNetwork network={network} /> */} |
There was a problem hiding this comment.
You can delete that comments testnet will never be public
components/UI/navbar.tsx
Outdated
| color={theme.palette.secondary.dark} | ||
| /> | ||
| )} | ||
| </li> |
There was a problem hiding this comment.
Imo you can delete both of these buttons when the user is not connected using address ?
Simply because both are not useful for unconnected wallet
fricoben
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #258
close #236
! I made a test button to send test txs and test the notification modal that needs to be deleted before merging !