Fix conditional exports in package #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was literally creating a PR with this exact fix for exactly the same problem (bundling a lib that consumes leva with |
|
Thanks for the fix! |
lgarron
added a commit
that referenced
this pull request
Apr 3, 2021
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error I encountered in a dependent package (
pmndrs/leva) while building it with a barebonesesbuildconfig. According to the NodeJS docs, only"import","require","node"and"default"are valid keys,"module"is not:https://nodejs.org/api/packages.html#packages_conditional_exports
(Not sure if
"types"are considered by TS or not, so I left those in. Also shout-outs to @n1ru4l who correctly identified this problem 🥇 )