Add cr_overlap_any to test if there are any overlaps #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nh13
commented
May 10, 2022
| @@ -296,6 +297,47 @@ int64_t cr_overlap_int(const cgranges_t *cr, int32_t ctg_id, int32_t st, int32_t | |||
| return n; | |||
| } | |||
|
|
|||
| bool cr_overlap_any_bool(const cgranges_t *cr, int32_t ctg_id, int32_t st, int32_t en) | |||
There was a problem hiding this comment.
This is duplicated from cr_overlap_int. I could add an option to cr_overlap_int to just return 1 when the first overlapping interval is found, so that we have less code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight optimization when we only care if there exists an overlap, not which overlaps.