Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some problems about Reading OPUS files #1176

Closed
wants to merge 4 commits into from
Closed

Fix some problems about Reading OPUS files #1176

wants to merge 4 commits into from

Conversation

yangb05
Copy link
Contributor

@yangb05 yangb05 commented Oct 10, 2023

Please check this issue for the details.

@pzelasko
Copy link
Collaborator

I think I meant to incorporate only the change with the sampling rate parameter for ffmpeg. If you'd like to use read_opus_torchaudio it'd be better to wrap it as a separate audio backend and then the user can set it if they like. This is because it's not always faster than ffmpeg (in fact it can be much more slower, see: pytorch/audio#1994)

@yangb05 yangb05 closed this Oct 13, 2023
@yangb05
Copy link
Contributor Author

yangb05 commented Oct 13, 2023

There's some wrong oprations in this pull request since it's my first time to create pull request. I will close this one and open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangb05 @pzelasko