follow shellcheck suggestions

liamtoaldo · Feb 7, 2021 · 228ee70 · 228ee70
1 parent 3ed8781
commit 228ee70
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/build/docker/build.sh b/build/docker/build.sh
@@ -12,8 +12,8 @@ IMAGE_TAG="${IMAGE}:${TAG}"
 CONTAINER_NAME="${IMAGE}-${TAG}"
 
 clean () {
-	docker rm -f $CONTAINER_NAME && echo "cleaned up container ${CONTAINER_NAME}"
-	docker rmi -f $IMAGE_TAG && echo "cleaned up image ${IMAGE_TAG}"
+	docker rm -f "${CONTAINER_NAME}" && echo "cleaned up container ${CONTAINER_NAME}"
+	docker rmi -f "${IMAGE_TAG}" && echo "cleaned up image ${IMAGE_TAG}"
 }
 trap clean ERR
 
@@ -23,8 +23,8 @@ build () {
 		-t "${IMAGE_TAG}" \
        		-f build/docker/Dockerfile .
 
-	docker create -ti --name $CONTAINER_NAME $IMAGE_TAG bash
-	docker cp $CONTAINER_NAME:/app/build/artifacts/. build/artifacts/
+	docker create -ti --name "${CONTAINER_NAME}" "${IMAGE_TAG}" bash
+	docker cp "${CONTAINER_NAME}:/app/build/artifacts/." build/artifacts/
 }
 
 build