-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
拆了proceed2
#1708
Merged
nonameShijian
merged 26 commits into
libccy:PR-Branch
from
Rintim:Dev-Enhancement-IHateProceed2
Aug 14, 2024
Merged
拆了proceed2
#1708
nonameShijian
merged 26 commits into
libccy:PR-Branch
from
Rintim:Dev-Enhancement-IHateProceed2
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame-fork into Dev-Enhancement-IHateProceed2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR受影响的平台
所有平台
诱因和背景
proceed2
罪恶滔天,人所不齿,故拆了,顺带改了点内容PR描述
将
proceed2
拆成了不同函数,虽然大致逻辑没变将
Dockerfile
中的node.js
版本升到了20现在扩展可以通过增加
connect
属性来使联机可用,且支持更多的内容扩展更新
标准的扩展形式如下:
现在你可以简单的像添加
editable: false
来防止他人从游戏中更改扩展一样,添加connect: true
来使扩展在联机模式下可加载:这样就能使扩展在联机模式下也被读取,不用在通过特别的操作来逃逸无名杀的拒绝加载
不过此时,扩展的武将和卡牌依然无法在联机中读取,你需要在武将和卡牌除同样加上connect属性才行:
同时现在可以直接在
character
和card
下写诸如dynamicTranslate
等属性:为啥需要两个
connect
才能使扩展武将联机为了方便属性导入,目前的逻辑是直接将处理过的
package.character.character
和package.card.card
通过武将包和卡牌包的导入时函数进行导入,而武将包和卡牌包的函数仍然需要判断一遍connect
属性,故需要写两遍从逻辑上来说,不是所有的可联机扩展都对武将/卡牌进行了联机处理,也不是所有可联机武将/卡牌扩展的卡牌/武将都能联机——即使这在无名杀中或许并不常见——故并未做额外处理,联机武将和联机卡牌需要再次设置
connect: true
才能联机PR测试
测了,能跑
扩展适配
无需适配,但以前的联机框架能改就改,未来可能会炸
检查清单
master
分支character/rank.js
中添加对应的武将强度评级,并对双人武将/复姓武将添加name:xxx
的参数lib.translate
中加入语音文件的文字台词PR描述
中写入详细文档扩展适配
中写入详细文档诱因和背景
中明确链接到该issue.editorconfig
、eslint.config.mjs
和prettier.config.mjs
所规定的代码样式,并且已经通过prettier
格式化过代码