api.c: constify cgroup_get_procs() and cgroup_get_threads() arguments #1122

Workflow file for this run

.github/workflows/continuous-integration.yml at 0a97dd8

	# SPDX-License-Identifier: LGPL-2.1-only
	#
	# Continuous Integration Workflow for libcgroup
	#
	# Copyright (c) 2020-2021 Oracle and/or its affiliates.
	# Author: Tom Hromatka <[email protected]>
	#

	name: Continuous Integration
	on: ["push", "pull_request"]

	jobs:
	# Doc: https://github.com/redhat-plumbers-in-action/differential-shellcheck#usage
	differential-shellcheck:
	name: Differential ShellCheck
	if: github.event_name == 'pull_request'
	runs-on: ubuntu-latest

	permissions:
	contents: read
	security-events: write
	pull-requests: write

	steps:
	- uses: actions/checkout@v4
	with:
	fetch-depth: 0
	- name: Differential ShellCheck
	uses: redhat-plumbers-in-action/differential-shellcheck@v5
	with:
	severity: warning
	token: ${{ secrets.GITHUB_TOKEN }}

	flake8-lint:
	name: Lint
	runs-on: ubuntu-latest
	steps:
	- name: Install flake8 dependencies
	run: \|
	sudo apt-get update
	sudo apt-get install python3-flake8-quotes
	- name: Check out source repository
	uses: actions/checkout@v4
	- name: Set up Python environment
	uses: actions/setup-python@v5
	with:
	python-version: "3.8"
	- name: flake8 Lint
	uses: reviewdog/action-flake8@v3
	with:
	github_token: ${{ secrets.GITHUB_TOKEN }}

	checkpatch:
	name: Checkpatch Review
	runs-on: ubuntu-latest
	if: github.event_name == 'pull_request'

	permissions:
	contents: read
	pull-requests: read

	steps:
	- name: 'Calculate PR commits + 1'
	run: echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 1 ))" >> $GITHUB_ENV
	- uses: actions/checkout@v4
	with:
	ref: ${{ github.event.pull_request.head.sha }}
	fetch-depth: ${{ env.PR_FETCH_DEPTH }}
	- name: Run checkpatch review
	uses: webispy/checkpatch-action@v9
	env:
	GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

	doxygen:
	name: Doxygen
	# Only run Doxygen against the main branch
	if: github.ref_name == 'main'
	runs-on: ubuntu-latest

	steps:
	- uses: actions/checkout@v4
	with:
	submodules: false
	- uses: mattnotmitt/doxygen-action@v1
	with:
	working-directory: "./"
	doxyfile-path: "./doc/Doxygen"
	- name: Move the Doxygen Files
	run: sudo mv ./html doc/
	- name: Deploy Doxygen
	uses: peaceiris/actions-gh-pages@v3
	with:
	github_token: ${{ secrets.GITHUB_TOKEN }}
	publish_dir: ./doc/html
	publish_branch: doxygen/${{ github.ref_name }}

	unittests:
	name: Unit Tests
	runs-on: ubuntu-latest

	steps:
	- uses: actions/checkout@v4
	with:
	submodules: false
	- name: Initialize the directory
	uses: ./.github/actions/setup-libcgroup
	- name: Run unit tests
	run: \|
	pushd tests/gunit
	make check
	popd
	- name: Display test logs
	if: ${{ always() }}
	run: cat tests/gunit/test-suite.log
	- name: Collate code coverage results
	uses: ./.github/actions/code-coverage
	- name: Upload code coverage results
	uses: coverallsapp/github-action@master
	with:
	github-token: ${{ secrets.GITHUB_TOKEN }}
	path-to-lcov: ./lcov.total
	flag-name: "Unit Tests"
	parallel: True
	- name: Archive code coverage results
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Unit Test Code Coverage
	path: lcov.*

	distcheckv1:
	name: Cgroup v1 Dist Check
	runs-on: ubuntu-20.04

	steps:
	- name: Install container dependencies
	run: \|
	sudo apt-get update
	sudo apt-get install lxc lxd-installer
	- uses: actions/checkout@v4
	with:
	submodules: false
	- name: Initialize the directory
	uses: ./.github/actions/setup-libcgroup
	- name: Run make distcheck
	run: make distcheck
	- name: Display test logs
	if: ${{ failure() }}
	run: \|
	cat libcgroup-*/_build/sub/tests/ftests/ftests-wrapper.sh.log

	buildtests:
	name: Build tests
	runs-on: ubuntu-20.04

	steps:
	- name: Install dependencies
	run: \|
	sudo apt-get update
	- uses: actions/checkout@v4
	with:
	submodules: false
	- name: Initialize the directory
	uses: ./.github/actions/setup-libcgroup
	- name: Reconfigure libcgroup with systemd disabled
	run: CFLAGS="$CFLAGS -Werror" ./configure --sysconfdir=/etc --localstatedir=/var --enable-code-coverage --enable-opaque-hierarchy="name=systemd" --enable-python --enable-systemd=no
	- name: Build the library
	run: make
	- name: Reconfigure libcgroup with samples enabled
	run: CFLAGS="$CFLAGS -Werror" ./configure --sysconfdir=/etc --localstatedir=/var --enable-code-coverage --enable-opaque-hierarchy="name=systemd" --enable-python --enable-samples
	- name: Build the library
	run: make
	- name: Reconfigure libcgroup with systemd disabled and samples enabled
	run: CFLAGS="$CFLAGS -Werror" ./configure --sysconfdir=/etc --localstatedir=/var --enable-code-coverage --enable-opaque-hierarchy="name=systemd" --enable-python --enable-systemd=no --enable-samples
	- name: Build the library
	run: make

	nosystemd:
	name: Build without systemd enabled
	runs-on: ubuntu-20.04

	steps:
	- name: Update the system
	run: \|
	sudo apt-get update
	- uses: actions/checkout@v4
	with:
	submodules: false
	- name: Install dependencies
	run: \|
	sudo apt-get install libpam-dev lcov python3-pip python3-dev cmake bison flex byacc g++ autoconf automake libtool lcov -y
	- name: Install cython
	run: sudo pip install cython
	- name: Initialize submodules
	run: \|
	git submodule update --init --recursive
	pushd googletest/googletest
	git checkout release-1.8.0
	cmake -DBUILD_SHARED_LIBS=ON .
	make
	popd
	- name: Automake
	run: \|
	test -d m4 \|\| mkdir m4
	autoreconf -fi
	rm -fr autom4te.cache
	- name: Run configure with systemd disabled
	run: CFLAGS="$CFLAGS -Werror" ./configure --sysconfdir=/etc --localstatedir=/var --enable-code-coverage --enable-opaque-hierarchy="name=systemd" --enable-python --enable-systemd=no --enable-samples
	- name: Build the library
	run: make
	- run: lcov -i -d . -c -o lcov.base
	shell: bash
	- name: Run the unit tests
	run: \|
	pushd tests/gunit
	make check
	popd
	- name: Run the functional tests
	run: \|
	pushd src/python/build/lib.*
	export PYTHONPATH=$PYTHONPATH:$(pwd)
	popd
	pushd tests/ftests
	./ftests.py -l 10 -L ftests.log
	./ftests.py -l 10 -L ftests-nocontainer.log --skip 38,77,81 --no-container
	popd
	- name: Archive test logs
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: No systemd test logs
	path: ./*.log
	- name: Collate code coverage results
	uses: ./.github/actions/code-coverage
	- name: Upload code coverage results
	uses: coverallsapp/github-action@master
	with:
	github-token: ${{ secrets.GITHUB_TOKEN }}
	path-to-lcov: ./lcov.total
	flag-name: "No systemd Functional Tests"
	parallel: True
	- name: Archive code coverage results
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: No systemd Code Coverage
	path: lcov.*

	functionaltestsv1:
	name: Cgroup v1 Functional Tests
	runs-on: ubuntu-20.04

	steps:
	- name: Install container dependencies
	run: \|
	sudo apt-get update
	sudo apt-get install lxc lxd-installer
	- uses: actions/checkout@v4
	with:
	submodules: false
	- name: Initialize the directory
	uses: ./.github/actions/setup-libcgroup
	- name: Run functional tests
	run: \|
	# The cgroup v1 runner hosted by Github Actions doesn't allow
	# for exclusive cpusets. Thus, skip the cpuset automated test
	pushd src/python/build/lib.*
	export PYTHONPATH=$PYTHONPATH:$(pwd)
	popd
	pushd tests/ftests
	./ftests.py -l 10 -L ftests.log
	./ftests.py -l 10 -L ftests-nocontainer.log --skip 38 --no-container
	popd
	- name: Archive test logs
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Cgroup v1 test logs
	path: ./*.log
	- name: Collate code coverage results
	uses: ./.github/actions/code-coverage
	- name: Upload code coverage results
	uses: coverallsapp/github-action@master
	with:
	github-token: ${{ secrets.GITHUB_TOKEN }}
	path-to-lcov: ./lcov.total
	flag-name: "Cgroup v1 Functional Tests"
	parallel: True
	- name: Archive code coverage results
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Cgroup v1 Code Coverage
	path: lcov.*

	functionaltestsv1v2:
	name: Cgroup v1/v2 Functional Tests
	runs-on: ubuntu-20.04

	steps:
	- name: Mount cpuset cgroup v2 controller
	run: \|
	# unmount the cpuset v1 controller. This should make it available
	# in the v2 hierarchy after all references have been freed
	sudo umount /sys/fs/cgroup/cpuset
	# wait for the references to the cpuset controller to go away
	sleep 30
	cat /sys/fs/cgroup/unified/cgroup.controllers
	sudo su -c "echo +cpuset > /sys/fs/cgroup/unified/cgroup.subtree_control"
	cat /sys/fs/cgroup/unified/cgroup.subtree_control
	- name: Install container dependencies
	run: \|
	sudo apt-get update
	sudo apt-get install lxc lxd-installer
	- uses: actions/checkout@v4
	with:
	submodules: false
	- name: Initialize the directory
	uses: ./.github/actions/setup-libcgroup
	- name: Run functional tests
	run: \|
	pushd src/python/build/lib.*
	export PYTHONPATH=$PYTHONPATH:$(pwd)
	popd
	pushd tests/ftests
	make check
	popd
	- name: Display test logs
	if: ${{ always() }}
	run: \|
	cat tests/ftests/ftests-wrapper.sh.log
	- name: Archive test logs
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Cgroup v1v2 test logs
	path: tests/ftests/*.log
	- name: Collate code coverage results
	uses: ./.github/actions/code-coverage
	- name: Upload code coverage results
	uses: coverallsapp/github-action@master
	with:
	github-token: ${{ secrets.GITHUB_TOKEN }}
	path-to-lcov: ./lcov.total
	flag-name: "Cgroup v1/v2 Functional Tests"
	parallel: True
	- name: Archive code coverage results
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Cgroup v1v2 Code Coverage
	path: lcov.*

	functionaltestsv2_legacy:
	name: Cgroup v2 Functional Tests - legacy
	runs-on: cgroup-legacy

	steps:
	- uses: actions/checkout@v4
	with:
	submodules: false
	- name: Initialize the directory
	uses: ./.github/actions/setup-libcgroup
	- name: Run functional tests
	run: \|
	pushd src/python/build/lib.*
	export PYTHONPATH=$PYTHONPATH:$(pwd)
	popd
	pushd tests/ftests
	make check
	popd
	- name: Display test logs
	if: ${{ always() }}
	run: \|
	cat tests/ftests/ftests-wrapper.sh.log
	- name: Archive test logs
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Cgroup v2 test logs - legacy
	path: tests/ftests/*.log
	- name: Collate code coverage results
	uses: ./.github/actions/code-coverage
	- name: Upload code coverage results
	uses: coverallsapp/github-action@master
	with:
	github-token: ${{ secrets.GITHUB_TOKEN }}
	path-to-lcov: ./lcov.total
	flag-name: "Cgroup v2 Functional Tests - legacy"
	parallel: True
	- name: Archive code coverage results
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Cgroup v2 Code Coverage - legacy
	path: lcov.*

	functionaltestsv2_hybrid:
	name: Cgroup v2 Functional Tests - hybrid
	runs-on: cgroup-hybrid

	steps:
	- uses: actions/checkout@v4
	with:
	submodules: false
	- name: Initialize the directory
	uses: ./.github/actions/setup-libcgroup
	- name: Run functional tests
	run: \|
	pushd src/python/build/lib.*
	export PYTHONPATH=$PYTHONPATH:$(pwd)
	popd
	pushd tests/ftests
	make check
	popd
	- name: Display test logs
	if: ${{ always() }}
	run: \|
	cat tests/ftests/ftests-wrapper.sh.log
	- name: Archive test logs
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Cgroup v2 test logs - hybrid
	path: tests/ftests/*.log
	- name: Collate code coverage results
	uses: ./.github/actions/code-coverage
	- name: Upload code coverage results
	uses: coverallsapp/github-action@master
	with:
	github-token: ${{ secrets.GITHUB_TOKEN }}
	path-to-lcov: ./lcov.total
	flag-name: "Cgroup v2 Functional Tests - hybrid"
	parallel: True
	- name: Archive code coverage results
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Cgroup v2 Code Coverage - hybrid
	path: lcov.*

	functionaltestsv2_unified:
	name: Cgroup v2 Functional Tests - unified
	runs-on: cgroup-unified

	steps:
	- uses: actions/checkout@v4
	with:
	submodules: false
	- name: Initialize the directory
	uses: ./.github/actions/setup-libcgroup
	- name: Run functional tests
	run: \|
	pushd src/python/build/lib.*
	export PYTHONPATH=$PYTHONPATH:$(pwd)
	popd
	pushd tests/ftests
	make check
	popd
	- name: Display test logs
	if: ${{ always() }}
	run: \|
	cat tests/ftests/ftests-wrapper.sh.log
	- name: Archive test logs
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Cgroup v2 test logs - unified
	path: tests/ftests/*.log
	- name: Collate code coverage results
	uses: ./.github/actions/code-coverage
	- name: Upload code coverage results
	uses: coverallsapp/github-action@master
	with:
	github-token: ${{ secrets.GITHUB_TOKEN }}
	path-to-lcov: ./lcov.total
	flag-name: "Cgroup v2 Functional Tests - unified"
	parallel: True
	- name: Archive code coverage results
	if: ${{ always() }}
	uses: actions/upload-artifact@v4
	with:
	name: Cgroup v2 Code Coverage - unified
	path: lcov.*

	finalize:
	name: Finalize the test run
	if: ${{ always() }}
	needs: [unittests, functionaltestsv1, functionaltestsv1v2, functionaltestsv2_legacy,
	functionaltestsv2_hybrid, functionaltestsv2_unified, nosystemd]
	runs-on: ubuntu-latest
	steps:
	- name: Finalize code coverage results
	uses: coverallsapp/github-action@master
	with:
	github-token: ${{ secrets.GITHUB_TOKEN }}
	parallel-finished: True

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

api.c: constify cgroup_get_procs() and cgroup_get_threads() arguments #1122

Workflow file

api.c: constify cgroup_get_procs() and cgroup_get_threads() arguments #1122

Jobs

Run details

Workflow file for this run