-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] pylint - Fix quotes as per standards #440
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix multiple "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q001 Single quote multiline found but double quotes preferred" warning. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q003 Change outer quotes to avoid escaping inner quotes" warning. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q003 Change outer quotes to avoid escaping inner quotes" warning. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q001 Single quote multiline found but double quotes preferred" and multiple "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q001 Single quote multiline found but double quotes preferred" and multiple "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes preferred" warnings by adjusting two lines into single line. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q001 Single quote multiline found but double quotes preferred" and multiple "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q003 Change outer quotes to avoid escaping inner quotes" warning. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes" and "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q003 Change outer quotes to avoid escaping inner quotes" and "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred" warnings. Signed-off-by: Kamalesh Babulal <[email protected]>
In the Github workflow continuous integration::flake8-lint job, add new checks for standardizing Python quotes usage. This will help maintain the recommended quotes style in all new PR's. Signed-off-by: Kamalesh Babulal <[email protected]>
kamalesh-babulal
force-pushed
the
Fix-quotes
branch
from
August 14, 2024 05:38
b0281db
to
1fdf313
Compare
drakenclimber
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the cleanup, @kamalesh-babulal
@drakenclimber Thank you so much for the review. |
Pushed to main. Thanks @kamalesh-babulal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series fixes them
pylint
(Flake8-quotes) warnings acrossthe source tree.