Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] pylint - Fix quotes as per standards #440

Closed
wants to merge 39 commits into from

Conversation

kamalesh-babulal
Copy link
Contributor

This series fixes them pylint (Flake8-quotes) warnings across
the source tree.

Fix multiple "Q000 Double quotes found but single quotes preferred"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q001 Single quote multiline found but double quotes preferred"
warning.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q003 Change outer quotes to avoid escaping inner quotes" warning.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q003 Change outer quotes to avoid escaping inner quotes" warning.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q001 Single quote multiline found but double quotes preferred" and
multiple "Q000 Double quotes found but single quotes preferred"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q001 Single quote multiline found but double quotes preferred" and
multiple "Q000 Double quotes found but single quotes preferred"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes
preferred" warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes
preferred" warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes
preferred" warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes
preferred" warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes
preferred" warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes
preferred" warnings by adjusting two lines into single line.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes
preferred" warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes
preferred" warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q001 Single quote multiline found but double quotes preferred" and
multiple "Q000 Double quotes found but single quotes preferred"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q003 Change outer quotes to avoid escaping inner quotes" warning.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q003 Change outer quotes to avoid escaping inner quotes"
and "Q000 Double quotes found but single quotes preferred" warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q000 Double quotes found but single quotes preferred" warning.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q001 Single quote multiline found but double quotes
preferred" warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix "Q003 Change outer quotes to avoid escaping inner quotes" and
"Q000 Double quotes found but single quotes preferred" warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
Fix multiple "Q000 Double quotes found but single quotes preferred"
warnings.

Signed-off-by: Kamalesh Babulal <[email protected]>
@kamalesh-babulal kamalesh-babulal added this to the v3.2.0 milestone Aug 13, 2024
@kamalesh-babulal kamalesh-babulal self-assigned this Aug 13, 2024
In the Github workflow continuous integration::flake8-lint job, add
new checks for standardizing Python quotes usage. This will help
maintain the recommended quotes style in all new PR's.

Signed-off-by: Kamalesh Babulal <[email protected]>
Copy link
Member

@drakenclimber drakenclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the cleanup, @kamalesh-babulal

@kamalesh-babulal
Copy link
Contributor Author

@drakenclimber Thank you so much for the review.

@drakenclimber
Copy link
Member

Pushed to main. Thanks @kamalesh-babulal

@kamalesh-babulal kamalesh-babulal deleted the Fix-quotes branch October 8, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants