Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower minimum TTL to 600s #12

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Lower minimum TTL to 600s #12

merged 2 commits into from
Nov 14, 2024

Conversation

fabiante
Copy link
Contributor

This fixes that records can't be set with a TTL of 3600 to 10800.

Practice has shown that the Hosttech API does in fact support a TTL of 3600 which is why this client library should support that.

@MasterEvarior
Copy link
Collaborator

MasterEvarior commented Nov 13, 2024

Hi @fabiante

Thanks for your PR.

Practice has shown that the Hosttech API does in fact support a TTL of 3600 which is why this client library should support that.

Yep, you're right. It seems like they have changed something a while ago. I can't find it anywhere now but for a certain time there was a limit at 10800, which now seems to be gone.

The PR looks fine by me and the tests are OK. I'd appreciate it if you could also update the README to be current.

@fabiante
Copy link
Contributor Author

@MasterEvarior Sure. The readme states that at least 600 seconds must be used. According to the Hosttech DNS GUI I have always worked with a TTL of 3600, because the UI does not give smaller options.

I have tested the API and it seems the value from the README is the proper one:

image

Thus, I will now change the code to use 600 and update the README to reflect the actual behavior.

This fixes that records can't be set with a TTL between 600 to 10800.

Practice has shown that the Hosttech API does in fact support a TTL of 3600 which is why this client library should support that.
@fabiante fabiante changed the title Lower minimum TTL to 3600s Lower minimum TTL to 600s Nov 13, 2024
@MasterEvarior MasterEvarior merged commit 865809d into libdns:main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants