Fix RelateOp for empty geometry and closed linear geometry #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts on backporting, since the changeset is relatively large? |
Always nice to backport bug fixes, especially for something as core as spatial predicates. How far back can you just cherry-pick? |
Ports the RelateOp class from JTS and then applies the fixes in locationtech/jts#671 Fixes https://trac.osgeo.org/geos/ticket/1096
3.11? |
Sigh... that's not great. Oh well, I guess if someone really wants it they can complain loudly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following Trac ticket: https://trac.osgeo.org/geos/ticket/1096. It ports locationtech/jts#671.
As a side effect, it brings along the
BoundaryOpclass that has been in JTS for some time, and its associated tests.