Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle MSVC flag warnings #936

Closed
wants to merge 1 commit into from

Conversation

jmckenna
Copy link

@jmckenna jmckenna commented Jul 3, 2023

[ 16%] Building CXX object CMakeFiles/geos.dir/src/geomgraph/Depth.cpp.obj
cl : Command line warning D9025 : overriding '/W3' with '/W4'
Depth.cpp
[ 16%] Building CXX object CMakeFiles/geos.dir/src/geomgraph/DirectedEdge.cpp.obj
cl : Command line warning D9025 : overriding '/W3' with '/W4'
DirectedEdge.cpp
[ 16%] Building CXX object CMakeFiles/geos.dir/src/geomgraph/DirectedEdgeStar.cpp.obj
cl : Command line warning D9025 : overriding '/W3' with '/W4'
DirectedEdgeStar.cpp
[ 16%] Building CXX object CMakeFiles/geos.dir/src/geomgraph/Edge.cpp.obj
cl : Command line warning D9025 : overriding '/W3' with '/W4'
Edge.cpp
[ 16%] Building CXX object CMakeFiles/geos.dir/src/geomgraph/EdgeEnd.cpp.obj
cl : Command line warning D9025 : overriding '/W3' with '/W4'
EdgeEnd.cpp

@robe2
Copy link
Member

robe2 commented Jul 4, 2023

@jmckenna What version of VS are you running? or what switches are you using? Not seeing any notices or errors in our VS 2022 and VS 2019 bots so
I'm hesitant to upgrade CMake just for this, because then I think Ubuntu 20.04 and Debian 10 will no longer be able to build. Granted those are old systems and probably hopefully won't be used much by the time we release GEOS 3.13 but I think still relatively widely used.

@jmckenna
Copy link
Author

jmckenna commented Jul 4, 2023

@robe no problem at all, closing.

@jmckenna jmckenna closed this Jul 4, 2023
@jmckenna
Copy link
Author

Coming back here with VS 2022, great that the easy fix is discoverable now through this ticket, and sometimes that is just as good for packagers (avoids a firestorm debate ha). Have a nice weekend all.

@jmckenna
Copy link
Author

Great to see that this ticket is still discoverable and still used by other packagers. Sometimes this is just as good as a merged pull request (see recent thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants