Fix WKTWriter to emit EMPTY elements in multi-geometries #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
force-pushed
the
fix-wkt-atomic-multi-geoms-with-one-or-more-empties
branch
2 times, most recently
from
b4bfe3a to
6429ffd
Compare
dr-jts
reviewed
Aug 29, 2023
|
Just to be clear: this is fixing the WKT parser so that it preserves empty elements in Multi-geometries? |
|
the WKT parser is fine, just issues with the WKT writer. Also there were no issues with GeometyCollection but the tests were added to cover these scenarios too. |
|
Perhaps a better title is "Fix WKTWriter to emit EMPTY elements in Multi-geometries"? |
mwtoews
force-pushed
the
fix-wkt-atomic-multi-geoms-with-one-or-more-empties
branch
from
7af1886 to
8ffc4c2
Compare
mwtoews
changed the title
mwtoews
deleted the
fix-wkt-atomic-multi-geoms-with-one-or-more-empties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #951