Stop depending on OpenSSL on linux #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The final choice of images for the |
|
Depending on how libgit2/libgit2sharp#1618 turns out, we may want to disable HTTPS on Windows and macOS as well and just always use the managed implementation. |
5 tasks
bording
changed the title
|
This is also bringing in the arm support provided by @qmfrederik in #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off the ideas in #77, I'm hoping we can drastically simplify the native binary story by building libgit2 with HTTPS support in linux, removing the OpenSSL dependency that is so problematic.
Since Windows and macOS have OS-level support for HTTPS, we can still use the libgit2 support for those systems.
Linux will be the only place where we'll need to rely on LibGit2Sharp to provide a managed implementation.